feat(kpa1500): one-touch amplifier ATU tune (FR-AMP-04) - #186
Open
dc0sk wants to merge 1 commit into
Open
Conversation
Add an ATU TUNE control to the amp window that runs the KPA1500's full-search tune. It keys the K4 with a steady carrier (TU1) and sends ^FT, then drops the carrier (TU0) when the amp reports completion (^TP seen start->stop), after a 20 s hard timeout, or when a precondition drops (amp or K4 link down, or TX disarmed). Because it keys the transmitter it reuses the K4 tune's safety model: arm-gated (refused with the ARM-TX flash when disarmed), and aborted by the emergency stop, which also sends ^FE so the amp stops searching. The hard timeout is the key safety property — the carrier can never be stranded on air if the tune hangs or a ^TP reply is missed. The end-decision is a pure, tested function (ui::amp_tune_should_end); the reconciliation runs on the tick. Verified on screen against a mock KPA1500 (extended to simulate a tune): the disarmed window shows the ATU TUNE button and an "arm TX to tune" hint. The armed carrier round-trip is a transmit path and remains HIL. This closes the tune deferred by FR-AMP-03. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KiAgfnGv746wwVBSfFkoRY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fourth slice: the one-touch ATU tune that FR-AMP-03 deferred. An ATU TUNE control in the amp window runs the KPA1500's full-search tune.
TU1) + starts the amp search (^FT), then drops the carrier (TU0) on completion (^TPseen start→stop), a 20 s hard timeout, or any dropped precondition (amp/K4 link down, TX disarmed).^FE).^TPreply is missed.Verification
ui::amp_tune_should_endis a pure function, unit-tested over 6 cases (fr_amp_04_tune_end_conditions): keeps running mid-tune, ends on start→stop, ends on timeout even if the amp never reported starting, ends on each dropped precondition.^FT→^TP1~2 s→^TP0,^FEcancels); the disarmed amp window shows the ATU TUNE button and the "arm TX to tune" hint (screenshot verified).xtask tracegreen.🤖 Generated with Claude Code