Skip to content

L3 VPP Aggregator Context Loaded - #320

Open
dcplatforms wants to merge 1 commit into
mainfrom
l3-weekly-vpp-run-6408370107421924491
Open

L3 VPP Aggregator Context Loaded#320
dcplatforms wants to merge 1 commit into
mainfrom
l3-weekly-vpp-run-6408370107421924491

Conversation

@dcplatforms

@dcplatforms dcplatforms commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Verified L3 vpp-aggregator tests and acknowledged instructions for weekly run.


PR created automatically by Jules for task 6408370107421924491 started by @dcplatforms


Note

Medium Risk
Changes how available VPP capacity is computed when safety context telemetry is missing or malformed, which can zero out reported capacity; scope is limited to the aggregator service.

Overview
Tightens how GET /capacity/available reads L1 safetyContext physics_score and confidence_score: scores are parsed with parseFloat so invalid values stay NaN for fidelity flags, and if either score is NaN the physics multiplier is forced to 0.0 instead of derating with substituted zeros via Math.min.

Parse failures in that path now log an error instead of failing silently. The background updateGlobalCapacity job fixes a variable mix-up by assigning confidence into rawConfidenceScore (not confidenceScore).

Reviewed by Cursor Bugbot for commit 3371b8b. Configure here.

Co-authored-by: dcplatforms <10982057+dcplatforms@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3371b8b. Configure here.

physicsMultiplier = 0.0;
} else {
physicsMultiplier = Math.min(physicsScoreRaw, confidenceScoreRaw);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing score zeros fleet capacity

Medium Severity

In GET /capacity/available, physics_score and confidence_score are parsed with bare parseFloat, so an omitted field becomes NaN and forces physicsMultiplier to 0.0. The background updateGlobalCapacity path still defaults missing values through safeFloat to 1.0, so the same Redis safety context can report zero fleet capacity while global aggregation keeps normal derating.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3371b8b. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant