Fix Smash Up extra play timing - #5
Open
deathcats4 wants to merge 991 commits into
Open
Conversation
deathcats4
pushed a commit
that referenced
this pull request
Aug 8, 2026
合并 deathcats24 的 PR #5，添加 POD（Print on Demand）派系支持。 新增功能： - 21 个 POD 派系文件（aliens_pod, bear_cavalry_pod, cthulhu_pod 等） - 新增 SmashUpCardRenderer 和 SmashUpOverlayContext UI 组件 - 英文图集映射（englishAtlasMap.json） 冲突解决策略： - 保留本地的核心 bug 修复（海盗王重复触发、MINION_PLAYED 去重、计分流程优化） - 接受 PR 的新增文件和功能 - 国际化文件保留本地版本（POD factions 会有自己的 i18n key） 修复： - 修复 SmashUpCardRenderer 函数名（小写改大写，符合 React Hook 规则） 测试状态： - TypeScript 编译通过（npx tsc --noEmit） - 核心 bug 修复保留完整 - POD factions 新增文件已合并
deathcats4
pushed a commit
that referenced
this pull request
Aug 8, 2026
1. 删除 matchSocket.ts 中重复的 _cleanupVisibility 成员定义 2. 注释掉 cardAtlas.ts 中缺失的 atlas-config.json import（PR 不完整） TODO: 等 deathcats24 补充 atlas-config.json 文件后启用 TTS 英文图集支持
deathcats4
pushed a commit
that referenced
this pull request
Aug 8, 2026
修复的问题: 1. miskatonic_mandatory_reading - 重新添加 addPermanentPower 函数 2. robot_hoverbot - 修复从牌库打出随从时的牌库状态可见性 3. robot_microbot_fixer & reclaimer - 避免 minionsPlayed 重复计算 4. coreProperties - 修正测试断言检查正确的字段 测试结果: - Test Files: 229 passed | 3 skipped (232) - Tests: 3042 passed | 7 skipped (3049) - 通过率: 99.77% 关键技术点: - 区分三种力量修正类型 (powerCounters/powerModifier/tempPowerModifier) - postProcessSystemEvents 中条件性 reduce fromDeck 事件 - 确保 onPlay 触发器看到正确的游戏状态 详见: pr5-fix-summary-final.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation