feat: PBEngineInfo.total_runtime_f64 - #476
Open
robtfm wants to merge 1 commit into
Open
Conversation
`total_runtime` is a proto float, and an f32 can't resolve frame deltas once a scene has been running for ~36 hours, which long-lived server scenes now do. The field can't be widened in place: generated decoders guard the wire type (fixed32 vs fixed64) and would skip it, so existing bundles would read 0. Add a double alongside; old bundles ignore the unknown field. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Test this pull request
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
total_runtimeis a protofloat, and an f32 can't resolve frame deltas once a scene has been running for ~36 hours, which long-lived server scenes now do (at a 30 Hz tick the resolution equals the tick period after ~3 days).The field can't be widened in place: generated decoders (e.g. the SDK's
engine_info.gen.ts) guard the wire type, fixed32 vs fixed64, and would skip the field, so every existing scene bundle would read 0. This addsdouble total_runtime_f64 = 5alongside; old bundles ignore the unknown field, new ones can read the wide value.Written by bevy-explorer in decentraland/bevy-explorer#1205.
🤖 Generated with Claude Code