Keep PR review collaboration alive beyond author sessions#573
Draft
baicaicc wants to merge 1 commit into
Draft
Conversation
PR handoffs previously depended on ad-hoc chats and a live author session. Add an idempotent PR Room lifecycle that creates or adopts a Feishu group, prepares local and federated reviewer agents, persists setup intent, and lets the author repair or finish the room safely. Constraint: Feishu bot open_id values are app-scoped, so remote reviewer readiness must be acknowledged by the owning deployment before kickoff. Constraint: Cross-deployment simultaneous open calls do not yet share a distributed uniqueness lock. Rejected: Retry expired or timed-out group creation automatically | could create duplicate review groups after an ambiguous remote success. Confidence: high Scope-risk: moderate Reversibility: clean Directive: Preserve the setup attempt token and finish-pending invariants before adding new PR Room side effects. Tested: pnpm build; tsc --noEmit; 63 targeted unit tests; full unit suite with only 15 baseline environment failures; dual code and architecture review. Not-tested: Live cross-deployment Feishu group creation against two production Botmux deployments.
baicaicc
marked this pull request as ready for review
July 23, 2026 13:22
Collaborator
Author
|
@deepcoldy 已完成实现并请求 Code Owner review。验证包括 我也用本分支实际创建了对应的 Botmux PR Room,双方 agent 已入群、作者 worktree 已绑定。由于你的部署尚未包含本 PR 新增的 |
baicaicc
marked this pull request as draft
July 23, 2026 13:30
Collaborator
Author
|
将此 PR 退回 Draft,暂停实现推进与合入。 原因:这个能力涉及 Botmux 的群组、federation、session、权限信任、调度和生命周期边界,应该先完成对既有能力与架构的系统盘点,再决定是否需要新增 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
botmux pr-room open|adopt|repair|finish|listfor a durable PR-scoped Feishu review group.adoptorfinish + --reopenreconciliation.Why
PR review handoffs currently depend on an ad-hoc group and a live author session. If the author session closes or the Owner creates a separate group, agent context and follow-up can be lost. PR Rooms make the collaboration durable and recoverable until merge, close, or explicit abandonment.
Safety and concurrency
finishwaits for a live setup attempt, then resolves atomically.Validation
pnpm buildtsc --noEmitnode:sqlite, fake Codex ESM fixture, Linux process scan/timeouts, hook/MCP sandbox environment)git diff --checkKnown boundary
Cross-deployment simultaneous
opencalls do not yet share a distributed uniqueness lock. The documented contract is to invokeopenfrom the PR author's hub/main deployment.