Skip to content

gpio: phytium: update phytium gpio controller driver support to 6.6.0.4#1827

Open
xiaqian1486 wants to merge 3 commits into
deepin-community:linux-6.6.yfrom
xiaqian1486:gpio-6.6.y
Open

gpio: phytium: update phytium gpio controller driver support to 6.6.0.4#1827
xiaqian1486 wants to merge 3 commits into
deepin-community:linux-6.6.yfrom
xiaqian1486:gpio-6.6.y

Conversation

@xiaqian1486

Copy link
Copy Markdown
Contributor

This patches updates the support for phytium gpio controller driver.

  1. Rebind parent chained handler after resuming from S4
  2. Remove redundant enable_irq in chained handler setup
  3. Add PCI and platform dependency

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we are unable to review this pull request

The GitHub API does not allow us to fetch diffs exceeding 300 files, and this pull request has 347

@deepin-ci-robot

Copy link
Copy Markdown

Hi @xiaqian1486. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Avenger-285714 Avenger-285714 requested a review from Copilot June 9, 2026 06:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Fix module (=m) case where GPIO interrupts stop after S4 resume
because the parent IRQ loses the chained handler setting up at probe.
So rebind the handler for each parent in resume() to restore
parent-to-child dispatch. While builtin (=y) builds unaffected.

Mainline: Open-Source
Signed-off-by: zhuling <zhuling2709@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Signed-off-by: Xia Qian <xiaqian1486@phytium.com.cn>
Linux PM framework automatically calls suspend_device_irqs() during
suspend to disable IRQs, and resume_device_irqs() during resume to
re-enable them. The current GPIO driver redundantly calls enable_irq()
in its resume flow, which will create an unbalanced IRQ enable since
the kernel has already restored the IRQ state through resume_device_irqs().

Mainline: Open-Source
Signed-off-by: Zhu Ling <zhuling2709@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Signed-off-by: Xia Qian <xiaqian1486@phytium.com.cn>
Ensure the Phytium GPIO PCI driver is only selectable for its intended
environment. This driver depends on both the Phytium platform and a
working PCI subsystem.

Mainline: Open-Source
Signed-off-by: Zhu Ling <zhuling2709@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Signed-off-by: Xia Qian <xiaqian1486@phytium.com.cn>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread drivers/gpio/Kconfig
Comment on lines 1725 to 1728
config GPIO_PHYTIUM_PCI
tristate "Phytium GPIO PCI support"
depends on PCI && ARCH_PHYTIUM
select GPIO_PHYTIUM_CORE
Comment on lines +139 to +140
/* Rebind parent-to-child dispatch chain and enable parent IRQ lines. */
static void phytium_set_irq_chained_handler(struct phytium_gpio *gpio)
Comment on lines +147 to +149
irq_set_chained_handler_and_data(gpio->irq[i],
phytium_gpio_irq_handler, &gpio->gc);
}
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opsiff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants