Skip to content

[Deepin-Kernel-SIG] [linux 6.6.y] [Upstream] Sync Input atkbd fixup from mainline#1853

Merged
opsiff merged 2 commits into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2026-06-12-atkbd
Jun 12, 2026
Merged

[Deepin-Kernel-SIG] [linux 6.6.y] [Upstream] Sync Input atkbd fixup from mainline#1853
opsiff merged 2 commits into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2026-06-12-atkbd

Conversation

@opsiff

@opsiff opsiff commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary by Sourcery

Bug Fixes:

  • Ensure proper atkbd handling on Lenovo Yoga Air 14 (83QK) and HONOR BCC-N systems by applying the deactivation fixup.

wangzy85222 and others added 2 commits June 12, 2026 11:09
mainline inclusion
from mainline-v7.1-rc7
category: bugfix

The Lenovo Yoga Air 14 (83QK) laptop keyboard becomes unresponsive
after the standard atkbd init sequence. Controlled testing on the
actual hardware shows the F5 (ATKBD_CMD_RESET_DIS / deactivate)
command specifically corrupts the EC state, causing zero IRQ1
interrupts after init.

Skipping only the deactivate command (while keeping F4 ENABLE)
resolves the issue completely: both keystroke input and CapsLock
LED toggle work correctly. The reverse test - skipping only F4
while keeping F5 - makes the problem worse (zero keystroke
interrupts), confirming F5 is the sole culprit.

Add a DMI quirk entry for LENOVO/83QK using the existing
atkbd_deactivate_fixup callback, consistent with the existing
entries for LG Electronics and HONOR FMB-P that address the
same EC F5 deactivate issue.

Signed-off-by: Zeyu WANG <zeyu.thomas.wang@gmail.com>
Link: https://patch.msgid.link/20260602170909.14725-1-zeyu.thomas.wang@gmail.com
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
(cherry picked from commit ad0979fe053e9f2db82da82188256ef6eb41095a)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
mainline inclusion
from mainline-v7.1-rc7
category: bugfix

After commit 9cf6e24 ("Input: atkbd -
do not skip atkbd_deactivate() when skipping ATKBD_CMD_GETID"), HONOR
BCC-N, aka HONOR MagicBook 14 2026's internal keyboard stops
working. Adding the atkbd_deactivate_fixup quirk fixes it.

DMI: HONOR BCC-N/BCC-N-PCB, BIOS 1.04 04/07/2026

Fixes: 9cf6e24 ("Input: atkbd - do not skip atkbd_deactivate() when skipping ATKBD_CMD_GETID")
Reported-by: Hongfei Ren <lcrhf@outlook.com>
Link: colorcube/Linux-on-Honor-Magicbook-14-Pro#1 (comment)
Tested-by: Hongfei Ren <lcrhf@outlook.com>
Cc: stable@kernel.org
Signed-off-by: Cryolitia PukNgae <cryolitia.pukngae@linux.dev>
Link: https://patch.msgid.link/20260605-honor-v1-1-78e05e491193@linux.dev
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
(cherry picked from commit fb402386af4cdce108ff991a796386de55439735)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai

sourcery-ai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extends the atkbd DMI quirk table so that the generic atkbd deactivation fixup is applied on two additional laptop models (a Lenovo Yoga Air 14 83QK and an HONOR BCC-N system).

Sequence diagram for applying atkbd_deactivate_fixup via new DMI quirks

sequenceDiagram
    participant Kernel as kernel_init
    participant DMI as dmi_check_system
    participant Quirk as atkbd_dmi_quirk_table
    participant atkbd as atkbd_deactivate_fixup

    Kernel->>DMI: dmi_check_system(atkbd_dmi_quirk_table)
    DMI->>Quirk: check DMI_MATCH entries
    alt Lenovo_Yoga_Air_14_83QK
        Quirk-->>DMI: match SYS_VENDOR LENOVO + PRODUCT_NAME 83QK
        DMI->>atkbd: atkbd_deactivate_fixup()
    else HONOR_BCC_N
        Quirk-->>DMI: match SYS_VENDOR HONOR + PRODUCT_NAME BCC-N
        DMI->>atkbd: atkbd_deactivate_fixup()
    end
Loading

File-Level Changes

Change Details Files
Apply the existing atkbd_deactivate_fixup quirk to two additional laptop models via DMI matching.
  • Add a DMI quirk entry for Lenovo Yoga Air 14 (product 83QK) using atkbd_deactivate_fixup as the callback
  • Add a DMI quirk entry for HONOR BCC-N using atkbd_deactivate_fixup as the callback
drivers/input/keyboard/atkbd.c

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Avenger-285714

Copy link
Copy Markdown
Member

/approve

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • For consistency with the existing entries, consider adding a brief identifying comment above the HONOR BCC-N DMI quirk (similar to the Lenovo Yoga Air 14 comment) so future maintainers can quickly see which system it targets.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For consistency with the existing entries, consider adding a brief identifying comment above the HONOR BCC-N DMI quirk (similar to the Lenovo Yoga Air 14 comment) so future maintainers can quickly see which system it targets.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs upstream DMI quirk updates for the AT keyboard (atkbd) driver to ensure affected systems skip the “deactivate” path via the existing atkbd_deactivate_fixup callback.

Changes:

  • Add a DMI match entry for Lenovo Yoga Air 14 (83QK) to apply atkbd_deactivate_fixup.
  • Add a DMI match entry for HONOR BCC-N to apply atkbd_deactivate_fixup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@opsiff opsiff merged commit 222809a into deepin-community:linux-6.6.y Jun 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants