[Deepin-Kernel-SIG] [linux 6.6.y] [Upstream] Sync Input atkbd fixup from mainline#1853
Merged
opsiff merged 2 commits intoJun 12, 2026
Merged
Conversation
mainline inclusion from mainline-v7.1-rc7 category: bugfix The Lenovo Yoga Air 14 (83QK) laptop keyboard becomes unresponsive after the standard atkbd init sequence. Controlled testing on the actual hardware shows the F5 (ATKBD_CMD_RESET_DIS / deactivate) command specifically corrupts the EC state, causing zero IRQ1 interrupts after init. Skipping only the deactivate command (while keeping F4 ENABLE) resolves the issue completely: both keystroke input and CapsLock LED toggle work correctly. The reverse test - skipping only F4 while keeping F5 - makes the problem worse (zero keystroke interrupts), confirming F5 is the sole culprit. Add a DMI quirk entry for LENOVO/83QK using the existing atkbd_deactivate_fixup callback, consistent with the existing entries for LG Electronics and HONOR FMB-P that address the same EC F5 deactivate issue. Signed-off-by: Zeyu WANG <zeyu.thomas.wang@gmail.com> Link: https://patch.msgid.link/20260602170909.14725-1-zeyu.thomas.wang@gmail.com Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> (cherry picked from commit ad0979fe053e9f2db82da82188256ef6eb41095a) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
mainline inclusion from mainline-v7.1-rc7 category: bugfix After commit 9cf6e24 ("Input: atkbd - do not skip atkbd_deactivate() when skipping ATKBD_CMD_GETID"), HONOR BCC-N, aka HONOR MagicBook 14 2026's internal keyboard stops working. Adding the atkbd_deactivate_fixup quirk fixes it. DMI: HONOR BCC-N/BCC-N-PCB, BIOS 1.04 04/07/2026 Fixes: 9cf6e24 ("Input: atkbd - do not skip atkbd_deactivate() when skipping ATKBD_CMD_GETID") Reported-by: Hongfei Ren <lcrhf@outlook.com> Link: colorcube/Linux-on-Honor-Magicbook-14-Pro#1 (comment) Tested-by: Hongfei Ren <lcrhf@outlook.com> Cc: stable@kernel.org Signed-off-by: Cryolitia PukNgae <cryolitia.pukngae@linux.dev> Link: https://patch.msgid.link/20260605-honor-v1-1-78e05e491193@linux.dev Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> (cherry picked from commit fb402386af4cdce108ff991a796386de55439735) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExtends the atkbd DMI quirk table so that the generic atkbd deactivation fixup is applied on two additional laptop models (a Lenovo Yoga Air 14 83QK and an HONOR BCC-N system). Sequence diagram for applying atkbd_deactivate_fixup via new DMI quirkssequenceDiagram
participant Kernel as kernel_init
participant DMI as dmi_check_system
participant Quirk as atkbd_dmi_quirk_table
participant atkbd as atkbd_deactivate_fixup
Kernel->>DMI: dmi_check_system(atkbd_dmi_quirk_table)
DMI->>Quirk: check DMI_MATCH entries
alt Lenovo_Yoga_Air_14_83QK
Quirk-->>DMI: match SYS_VENDOR LENOVO + PRODUCT_NAME 83QK
DMI->>atkbd: atkbd_deactivate_fixup()
else HONOR_BCC_N
Quirk-->>DMI: match SYS_VENDOR HONOR + PRODUCT_NAME BCC-N
DMI->>atkbd: atkbd_deactivate_fixup()
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Member
|
/approve |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- For consistency with the existing entries, consider adding a brief identifying comment above the HONOR BCC-N DMI quirk (similar to the Lenovo Yoga Air 14 comment) so future maintainers can quickly see which system it targets.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- For consistency with the existing entries, consider adding a brief identifying comment above the HONOR BCC-N DMI quirk (similar to the Lenovo Yoga Air 14 comment) so future maintainers can quickly see which system it targets.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR syncs upstream DMI quirk updates for the AT keyboard (atkbd) driver to ensure affected systems skip the “deactivate” path via the existing atkbd_deactivate_fixup callback.
Changes:
- Add a DMI match entry for Lenovo Yoga Air 14 (83QK) to apply
atkbd_deactivate_fixup. - Add a DMI match entry for HONOR BCC-N to apply
atkbd_deactivate_fixup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bug Fixes: