test implement - #20
Merged
Merged
Conversation
Refs #19
IzaFerrari
force-pushed
the
izabely_normalizer2
branch
from
May 23, 2026 01:28
6d5c47f to
036c1ed
Compare
There was a problem hiding this comment.
Pull request overview
Adds stricter unit-test assertions for models/damicore_normalizer output format, addressing Issue #19 by validating the normalized text-file content and the returned naming-convention metadata.
Changes:
- Add a unit test asserting a representative generated
.txtfile does not include header column names. - Add a unit test asserting
normalize_datasetreturns the expectednaming_conventionstring for the current fixture’s key columns.
Comment on lines
+48
to
+52
| def test_output_file_has_no_header(contract: NormalizerInput) -> None: | ||
| result = normalize_dataset(contract) | ||
| output_dir = Path(result["output_directory_path"]) | ||
| sample_file = output_dir / "80001_2000_00a04.txt" | ||
|
|
Comment on lines
+47
to
+49
| @pytest.mark.unit | ||
| def test_output_file_has_no_header(contract: NormalizerInput) -> None: | ||
| result = normalize_dataset(contract) |
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
enniolopes
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #19