Skip to content

fix(core): make Unix pipe fd ownership explicit - #36353

Open
nathanwhit wants to merge 1 commit into
denoland:mainfrom
nathanwhit:fix/unix-pipe-fd-ownership
Open

fix(core): make Unix pipe fd ownership explicit#36353
nathanwhit wants to merge 1 commit into
denoland:mainfrom
nathanwhit:fix/unix-pipe-fd-ownership

Conversation

@nathanwhit

Copy link
Copy Markdown
Member

Summary

  • keep raw Unix pipe descriptors owned by the pipe handle until ownership is transferred
  • make Tokio streams and listeners the sole closer after connect, accept, or listen
  • retain explicit cleanup for descriptor-only pipes and non-owning AsyncFd registrations
  • cover raw, listener, accepted-stream, and bound-connect ownership transitions

Tests

  • ./tools/format.js
  • cargo test -p deno_core 'uv_compat::tests' --lib
  • cargo clippy -p deno_core --lib --no-deps -- -D warnings
  • cargo build -p deno --bin deno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant