fix(xlsx): preserve fill boundary crossings - #1500
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1475
Summary
The page-1 title/body boundary now stays continuous at both pale-cell intersections. The same rule removes four page-2 conditional-fill notches without moving text or changing surrounding fill extents.
Related issue
Fixes #1475. Related: #982, #1472.
Testing
cargo test -p office2pdf render::typst_gen::tests::table_codegen_tests::table_border_tests— 40 passedcargo test --workspace— passed, including 2,802 office2pdf library tests and all DOCX/PPTX/XLSX fixture suitespython3 -m unittest discover -s scripts/tests— 326 passedcargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo check --target wasm32-unknown-unknown -p office2pdfcargo check --target wasm32-unknown-unknown -p office2pdf --features wasmcargo check --target wasm32-unknown-unknown -p office2pdf --features wasm-cjk-fontwasm-pack build crates/office2pdf --target web --features wasmqpdf --check target/issue-1475/after-final.pdfPASSVisual impact
Visual audit
Gift Budget and Tracker1.xlsxattachment from Gift Budget and Tracker1.xlsx misc issues #982, SHA-25625f5dc75dab19ea12042979a61842314ddc226e3e45d447e36b2a2a104112613fixassets/bugfixes/issue-1475/layout-audit.jsonassets/bugfixes/issue-1475/render-clusters-page-1.json,assets/bugfixes/issue-1475/render-clusters-page-2.jsonassets/bugfixes/issue-1475/gt.jpgassets/bugfixes/issue-1475/before.jpgassets/bugfixes/issue-1475/after.jpgVisual comparison
Fresh Poppler and MuPDF renders at 300 DPI both show the two page-1 pale notches in the before PDF and a continuous rose boundary in the after PDF.
The page-2 audit retains two 1pt adjacent-colour corner differences, both tracked in #1495. Before this change page 2 had six visible-fill mismatches, so four are fixed and none are newly introduced.
The PDF text-layer check reports two extra GT spaces because the native exporter fragments the source phrase
Birthday BudgetasBirt hday Bu dget. The output preserves the workbook source phrase, so this is a GT text-fragmentation artifact rather than output content loss.Required inspection
Deviation audit
Checklist
Signed-off-byline