Skip to content

fix(xlsx): center filled merged titles on visible band - #1502

Merged
developer0hye merged 1 commit into
mainfrom
fix/issue-1493-merged-center
Sep 1, 2026
Merged

fix(xlsx): center filled merged titles on visible band#1502
developer0hye merged 1 commit into
mainfrom
fix/issue-1493-merged-center

Conversation

@developer0hye

Copy link
Copy Markdown
Owner

Summary

  • center an Excel filled horizontal merge on the visible boundary-band region
  • apply the seat to the placed spill line without changing its measurement region
  • keep unfilled, left-aligned, non-Excel, and unshifted spill-cell output unchanged
  • add an actual-layout regression that varies fill and center/left alignment

Related issue

Fixes #1493

Testing

  • cargo test -p office2pdf a_centered_merged_fill_uses_the_excel_background_band_for_its_text_seat -- --nocapture
  • cargo test -p office2pdf spill_cell -- --nocapture
  • cargo test -p office2pdf a_spill_clip_box_stops_at_the_cell_edge_its_anchor_faces -- --nocapture
  • cargo test --workspace --quiet
  • python3 -m unittest discover -s scripts/tests (326 tests)
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo check --target wasm32-unknown-unknown -p office2pdf
  • cargo check --target wasm32-unknown-unknown -p office2pdf --features wasm
  • cargo check --target wasm32-unknown-unknown -p office2pdf --features wasm-cjk-font
  • wasm-pack build crates/office2pdf --target web --features wasm
  • qpdf --check target/issue-1493/final.pdf
  • fresh Poppler and MuPDF 300-DPI full-page, diff, and matched-crop inspection

Visual impact

  • No rendered PDF change
  • Rendered PDF change or visual evidence added
  • Reason: the page-1 merged title moves 1pt right to Excel's visible-region center.

Visual audit

Visual comparison

GT Before After
GT Before After

Required inspection

  • Rendered all evidence at 150 DPI or higher
  • Stored progressive JPEG quality 86 assets with metadata stripped
  • Used Codex/Claude vision to inspect the full GT/output pages, diff, and matched crops
  • Inspected matched region crops at full resolution
  • Ran compare_layout.py --audit --fine-shift PT and dispositioned every fine/large text-instance shift, painted-text visibility mismatch, and visible-fill occlusion
  • Ran compare_render.py --cluster-report PATH --strict-clusters and dispositioned every material 5% fuzz diff cluster by explicit ID
  • Inventoried hairlines and border dash styles
  • Inventoried font weight, italic, and underline emphasis

Deviation audit

Check Result
Page count/order Matches GT
Element presence Matches GT
Position/size Remaining: #1210, #1494, #1496, #1497, #1498, #1499; Fixed #1493
Rotation/flip Matches GT
Fill Matches GT
Stroke/border Matches GT
Shape outline geometry Matches GT
Text content Matches GT
Font family/weight/style Remaining: #1210
Text color Remaining: #1210
Alignment Fixed #1493
Line/paragraph spacing Remaining: #1494, #1497, #1498
Clipping/overflow Matches GT

Checklist

  • Commits include a Signed-off-by line
  • PR scope contains one root cause
  • Remaining visual deviations each reference an open issue

Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
@developer0hye
developer0hye merged commit cd8d4db into main Sep 1, 2026
18 checks passed
@developer0hye
developer0hye deleted the fix/issue-1493-merged-center branch September 1, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XLSX: a merged centered title uses the nominal track width, seating it 1.04pt left of Excel

1 participant