fix(xlsx): center filled merged titles on visible band - #1502
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Fixes #1493
Testing
cargo test -p office2pdf a_centered_merged_fill_uses_the_excel_background_band_for_its_text_seat -- --nocapturecargo test -p office2pdf spill_cell -- --nocapturecargo test -p office2pdf a_spill_clip_box_stops_at_the_cell_edge_its_anchor_faces -- --nocapturecargo test --workspace --quietpython3 -m unittest discover -s scripts/tests(326 tests)cargo clippy --workspace --all-targets -- -D warningscargo check --target wasm32-unknown-unknown -p office2pdfcargo check --target wasm32-unknown-unknown -p office2pdf --features wasmcargo check --target wasm32-unknown-unknown -p office2pdf --features wasm-cjk-fontwasm-pack build crates/office2pdf --target web --features wasmqpdf --check target/issue-1493/final.pdfVisual impact
Visual audit
Gift Budget and Tracker1.xlsx(25f5dc75dab19ea12042979a61842314ddc226e3e45d447e36b2a2a104112613)fixassets/bugfixes/issue-1493/layout-audit.jsonassets/bugfixes/issue-1493/render-clusters-page-1.json,assets/bugfixes/issue-1493/render-clusters-page-2.jsonassets/bugfixes/issue-1493/gt.jpgassets/bugfixes/issue-1493/before.jpgassets/bugfixes/issue-1493/after.jpgVisual comparison
Required inspection
Deviation audit
Checklist
Signed-off-byline