fix(xlsx): seat centered multi-row text blocks - #1507
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Fixes #1497
Testing
cargo test --locked -p office2pdf centered_two_row_sheet_merge_uses_the_full_fixed_track_seat -- --nocapturecargo test --locked -p office2pdf sheet_cell -- --nocapture(28/28)cargo test --locked -p office2pdf row_spanning_cell_keeps_its_declared_alignment_in_a_tight_row -- --nocapturecargo test --locked -p office2pdf centered_fixed_sheet_rows_share_one_center_across_two_and_three_wrapped_lines -- --nocaptureperf_medium_xlsx_conversion_under_30_secondsat 33.52s after the long rendering suites; its unchanged isolated rerun passed at 12.933s, and no threshold or fixture was changedpython3 -m unittest discover -s scripts/tests -p 'test_*.py'(326 tests; 30 business mocks and stored layout baseline included)cargo fmt --checkgit diff --checkcargo check --locked --workspacecargo clippy --locked --workspace --all-targets -- -D warningscargo check --locked --target wasm32-unknown-unknown -p office2pdfcargo check --locked --target wasm32-unknown-unknown -p office2pdf --features wasmcargo check --locked --target wasm32-unknown-unknown -p office2pdf --features wasm-cjk-fontwasm-pack build crates/office2pdf --target web --features wasmwasm-pack build crates/office2pdf --target web --features wasm-cjk-fontCARGO_PROFILE_DEV_DEBUG=0: 10/10 general and 11/11 CJK passed08_budget_ko.xlsxchanges only its two vertically centred multi-row merge labels by +0.1366pt, toward the stored golden positions, with unchanged x/width/wraps/fills/100 rectangles; all 20 PDFs passqpdf --checkqpdf --check target/issue-1497/after.pdfVisual impact
Visual audit
Gift Budget and Tracker1.xlsx(25f5dc75dab19ea12042979a61842314ddc226e3e45d447e36b2a2a104112613)ed705d89307735651eb67abedb59d014666b2567aa3be73eabd7f4518dd8f6598e014bf9316ba4259f9e8e55c9afe6facbbba0e8a460b5e2a49da9ff7632ad9efixassets/bugfixes/issue-1497/layout-audit.jsonassets/bugfixes/issue-1497/render-clusters-page-1.json,assets/bugfixes/issue-1497/render-clusters-page-2.json$140tick (XLSX chart: one middle value-axis tick sits 0.70pt above its peers #1499), and sensitivity footer (XLSX: a header/footer run before the first font code takes the Normal font's family but not its size or colour #1210).assets/bugfixes/issue-1497/gt.jpgassets/bugfixes/issue-1497/before.jpgassets/bugfixes/issue-1497/after.jpgVisual comparison
Required inspection
Deviation audit
GT integrity
B2:D3over two declared 49.5pt rows; this corrects the original issue body's 40pt description without changing the measured acceptance targetChecklist
Signed-off-bylinePASS:before commit