fix(xlsx): keep declared wrapped line pitch - #1508
Merged
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Fixes #1498
Testing
CARGO_INCREMENTAL=0 cargo test --locked -p office2pdf substituted_sheet_face_keeps_the_declared_excel_wrapped_advance -- --nocaptureCARGO_INCREMENTAL=0 cargo test --locked -p office2pdf wrapped_sheet_cell_paces_its_lines_on_excels_advance -- --nocaptureCARGO_INCREMENTAL=0 cargo test --locked -p office2pdf sheet_cell -- --nocapture(28/28)CARGO_INCREMENTAL=0 cargo test --locked -p office2pdf centered_fixed_sheet_rows_share_one_center_across_two_and_three_wrapped_lines -- --nocaptureCARGO_INCREMENTAL=0 cargo test --locked --workspace(2,814 library tests plus DOCX/PPTX/XLSX/public-visual/PDF/CLI/package integration suites and doctests passed; documented ignores unchanged)python3 -m unittest discover -s scripts/tests -p 'test_*.py'(326 tests; 30 business mocks and stored layout baseline included)cargo fmt --all -- --checkgit diff --checkCARGO_INCREMENTAL=0 cargo check --locked --workspaceCARGO_INCREMENTAL=0 cargo clippy --locked --workspace --all-targets -- -D warningsCARGO_INCREMENTAL=0 cargo check --locked --target wasm32-unknown-unknown -p office2pdfCARGO_INCREMENTAL=0 cargo check --locked --target wasm32-unknown-unknown -p office2pdf --features wasmCARGO_INCREMENTAL=0 cargo check --locked --target wasm32-unknown-unknown -p office2pdf --features wasm-cjk-fontCARGO_INCREMENTAL=0 wasm-pack build crates/office2pdf --target web --features wasmCARGO_INCREMENTAL=0 wasm-pack build crates/office2pdf --target web --features wasm-cjk-fontCARGO_PROFILE_DEV_DEBUG=0: 10/10 general and 11/11 CJK passedqpdf --checkqpdf --check target/issue-1498/after.pdfVisual impact
Visual audit
Gift Budget and Tracker1.xlsx(25f5dc75dab19ea12042979a61842314ddc226e3e45d447e36b2a2a104112613)ed705d89307735651eb67abedb59d014666b2567aa3be73eabd7f4518dd8f659; qpdf-clean working copy1926ebd14c061cb0c3040a96c80cdd65ae3a0b6e19f43a499fa5adf4389ea26ed8628df93bf19f7257c13081c527d357619602719590db1b6f43f2ed3093f260fixassets/bugfixes/issue-1498/layout-audit.jsonassets/bugfixes/issue-1498/render-clusters-page-1.json,assets/bugfixes/issue-1498/render-clusters-page-2.json$140tick (XLSX chart: one middle value-axis tick sits 0.70pt above its peers #1499) and sensitivity footer (XLSX: a header/footer run before the first font code takes the Normal font's family but not its size or colour #1210). The native GT text layer fragmentsBirthday Budgetwith two extra spaces, but the rendered text is visually intact and office2pdf's extracted text is correct.assets/bugfixes/issue-1498/gt.jpgassets/bugfixes/issue-1498/before.jpgassets/bugfixes/issue-1498/after.jpgVisual comparison
Required inspection
Deviation audit
Birthday Budget, with no rendered or office2pdf text lossGT integrity
qpdf --checkand decodes pixel-identically in Poppler and MuPDFI6,J6, andM6on the fixed 49.5pt row; this corrects the original issue body's stale font-size descriptionChecklist
Signed-off-bylinePASS:before commit