Skip to content

Image widget updated with gif , jpg support#21

Merged
developersharif merged 10 commits intomainfrom
image-widget
Apr 26, 2026
Merged

Image widget updated with gif , jpg support#21
developersharif merged 10 commits intomainfrom
image-widget

Conversation

@developersharif
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive Image widget that supports native Tcl/Tk formats (PNG, GIF, PPM/PGM) and adds support for JPEG and BMP via transparent transcoding using the GD extension. A significant feature is the built-in support for animated GIFs, which are handled by parsing GIF frames and driving the animation loop directly within the Tcl event loop. The PR also includes detailed documentation, an updated example application, and a new test suite. Feedback focused on improving the robustness of Tcl command generation and temporary file handling. Specifically, the Tcl escaping logic for widget options needs to be more resilient to trailing backslashes to prevent interpreter crashes, and the use of tempnam() was recommended for more secure temporary file creation.

Comment thread src/Widget/Image.php Outdated
Comment thread src/Widget/Image.php Outdated
@developersharif developersharif merged commit ce7e94d into main Apr 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant