Fail install-plugin.sh when an expected location is skipped (#200) - #210
Merged
Conversation
add_target dropped any directory that was not on disk at that instant and recorded nothing, so an iCloud plug-in folder that had not been materialised was skipped with no warning while the script still exited 0. The install looked completely successful and OmniFocus kept loading the stale copy from the folder that was missed -- observed on this machine, where the same script left iCloud stale in one run and updated both locations in the next with no code change between them. A location absent because the user does not use it is still skipped quietly. A location that is expected is now reported and fails the run: iCloud counts as expected whenever the OmniFocus iCloud container exists, which means plug-in sync is on, and an explicitly configured custom directory always counts. Partial installs exit 1 with guidance to open OmniFocus once so the folder materialises, and point at bridge-health-check, which reports every installed copy and warns when they disagree. Verified both paths: with the iCloud plug-in folder moved aside the script reports the skip and exits 1; with it present it exits 0 as before. Validation impact: package. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200. The diagnostic half shipped in #201; this is the installer half.
The defect
add_targetdropped any directory not on disk at that instant and recorded nothing about it. An iCloud plug-in folder that had not been materialised was therefore skipped silently, while the script still printed its success banner and exited 0.That is worse than a failed install: it looks completely successful, and OmniFocus keeps loading the stale copy from the folder that was missed. Observed directly on one machine — the same script left iCloud stale in one run and updated both locations in a later run, with no code change in between.
The fix
A location absent because the user does not use it is still skipped quietly. A location that is expected is now reported and fails the run:
Skipped locations are listed under their own heading, and a partial install exits 1 with guidance: open OmniFocus once so the folder materialises, then re-run. It also points at
bridge-health-check, which since #201 reports every installed copy and warns when they disagree.Verification
Both paths exercised on a real machine with iCloud plug-in sync enabled:
Validation
Impact:
packageperfocusrelay-dev classify. Validation passes: 317 tests, clean release build, version consistency checks.