Remove the unused benchmark verdict engine and refocus the roadmap - #213
Merged
Conversation
BenchmarkVerdict shipped in #211 with no caller: 130 lines of library plus ten tests that nothing in the product invoked. The part of #206 that earns its place is the coverage warning wired into classify, which catches the gap that cost four smoke suites on #88. Deleting the rest. #207 is closed and drops out of the delivery order. Its fix changed 233 lines while fixing nothing reachable -- the rootOnly gap already has a regression test from #88, and the batch path added in #171 does not touch the cache at all. #206 stays, rescoped to the work that is actually left: benchmarks for the six tools the suite cannot measure, to be added when a change to one of them needs measuring rather than in advance. Adds two standing decisions drawn from both mistakes: fix defects that have a reproduction rather than refactoring latent risk, and do not build tooling ahead of a caller. Validation impact: docs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup after review feedback that recent work was going down rabbit holes. It was.
Deletes
BenchmarkVerdict. It shipped in #211 with no caller — 130 lines of library plus ten tests that nothing in the product invoked. The half of #206 that earns its place is the coverage warning wired intoclassify, which catches the gap that cost four smoke suites while validating #88. That stays.Drops #207 from the roadmap (issue and PR #212 both closed). Its fix changed 233 lines while fixing nothing reachable: the
rootOnlygap already has a regression test from #88, and the batch path added in #171 does not touch the cache at all.Rescopes #206 to the work actually left — benchmarks for the six tools the suite cannot measure — to be added when a change to one of them needs measuring, not in advance.
Two new standing decisions, drawn from both mistakes:
324 tests pass.
validate --impact docspasses.