Fix/grep dedup - #7
Merged
Merged
Conversation
Extract shared error-tracking into an ErrorState struct with record_entry_error(), record_search_error(), and into_metadata() methods. Unify grep_content and grep_files into a single grep_streamed() function parameterized by a StreamMode enum (Content | FilesWithMatches), since both share the exact same walker + channel + early-quit structure. Extract build_matcher() and build_searcher() helpers that encapsulate the mode-specific searcher configuration (line numbers, context). Net result: -51 lines, elimination of ~30 redundant Arc::clone calls, and single points of change for entry validation, error recording, and response assembly logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.