fix(session): preserve multi-selection changes in persisted sessions#238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #237.
Session saves could fail after actions that create compound undo history, such as moving or editing properties for multiple selected strokes.
UndoActionused serde internal tagging, but itsCompound(Vec<UndoAction>)variant was a newtype variant, whichserde_jsoncannot serialize. This caused the session payload serialization failure and left the previous session file in place.This is intentionally narrow and builds on top of #236. It does not change the clear-marker, backup, recovery, or contentless-save behavior from #236; it only fixes serialization of compound undo history created by multi-selection edits