test(writer): kill behavioral VortexWriter survivors; parameterize dict-decision tests#101
Merged
Merged
Conversation
…ct-decision tests Two more genuinely-behavioral kills: - isUtf8DictCandidate cardinality-at-MAX boundary (`seen.size() > MAX` must not trip at exactly MAX). - rowCountForValidation on a Collection column: a two-column chunk (List<LocalDate> extension + same-length long[]) is accepted, pinning that the collection is measured by element count, not a constant. Also restructure VortexWriterDictDecisionTest into @ParameterizedTest with proper Given/When/Then: case params are the Given, `result = helper(...)` the When, the assertion the Then. VortexWriter 89% killed (strength 92%). The remaining survivors are encoding-choice mutants that round-trip identically (dict-vs-fallback, frequency sort, zstd codec list), 64-byte segment-alignment math, dead-by-exclusion ptype switch arms, or the impractical U32 code path — not correctness gaps. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #99/#100. Closes the remaining behavioral VortexWriter mutation survivors and tidies the dict-decision tests.
Kills
isUtf8DictCandidatecardinality-at-MAX —seen.size() > MAXmust not trip at exactly MAX (boundary).rowCountForValidationon a Collection column — a two-column chunk (List<LocalDate>extension + same-lengthlong[]) is accepted, pinning that the collection is measured by element count, not a constant.Cleanup
VortexWriterDictDecisionTestis now@ParameterizedTestwith proper Given/When/Then — the case params are the Given,result = helper(...)the When, the assertion the Then.Remaining survivors (~30, not chased — by design)
Honest accounting: these are not correctness gaps:
List.sort, the zstd codec-list toggle: all produce different-but-valid files that decode to the same values.VortexWriter sits at 89% killed (strength 92%); the global-dict decision layer and all behavioral paths are pinned.
Verify
🤖 Generated with Claude Code