Skip to content

refactor(reader): rename CLIENT to DEFAULT_HTTP_CLIENT #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfa1 merged 1 commit into from
Jun 20, 2026
+2 −2
Merged

refactor(reader): rename CLIENT to DEFAULT_HTTP_CLIENT #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions reader/src/main/java/io/github/dfa1/vortex/reader/VortexHttpReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public final class VortexHttpReader implements VortexHandle {
/// Shared across all instances. JDK HttpClient is heavyweight and designed for reuse;
/// per-reader instantiation would create redundant connection pools and selector threads.
/// Never closed: lifetime tracks the JVM.
private static final HttpClient CLIENT = HttpClient.newHttpClient();
private static final HttpClient DEFAULT_HTTP_CLIENT = HttpClient.newHttpClient();

private final URI uri;
private final HttpClient client;
Expand Down Expand Up @@ -66,7 +66,7 @@ public static VortexHttpReader open(URI uri) throws IOException {
}

public static VortexHttpReader open(URI uri, ReadRegistry registry) throws IOException {
return open(uri, registry, CLIENT);
return open(uri, registry, DEFAULT_HTTP_CLIENT);
}

/// Opens a remote Vortex file using a caller-supplied [HttpClient].
Expand Down