test(reader): unit-cover VortexHttpReader.open(uri, registry) overload#117
Merged
Conversation
The prior IT (#116) exercised the two-arg overload but @tag("integration") *IT classes run under failsafe, not surefire, so JaCoCo/Sonar never saw them — new-code coverage stayed at 50% and the quality gate stayed red. Replace it with a surefire unit test: a non-HTTP URI makes HttpRequest.newBuilder reject the scheme before any socket opens, so the delegation line runs offline with no real network I/O. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dfa1
added a commit
that referenced
this pull request
Jun 21, 2026
#117's unit test threw before the delegation completed, so JaCoCo's end-of-line probe never fired and new-code coverage stayed at 50% (JaCoCo marks an always-throwing line as missed). Make the shared default HttpClient a package-private non-final seam so a unit test can substitute the mock fixture used by VortexHttpReaderTailFetchTest and drive the two-arg overload to a normal return — now the probe fires and the line is covered. Production never reassigns the field. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prior IT (#116) exercised the two-arg overload but @tag("integration")
*IT classes run under failsafe, not surefire, so JaCoCo/Sonar never saw
them — new-code coverage stayed at 50% and the quality gate stayed red.
Replace it with a surefire unit test: a non-HTTP URI makes
HttpRequest.newBuilder reject the scheme before any socket opens, so the
delegation line runs offline with no real network I/O.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com