Fix Wikimedia photos still not loading on Android#57
Merged
Conversation
Image.android.js only forwards the `headers` prop to the native view
when `source` resolves to an array — for a plain `{uri, headers}`
object it drops them silently, so the User-Agent fix from #38 never
actually reached the network request. Return a single-element array
instead so Android's Image pipeline picks up the header.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfalling
enabled auto-merge (squash)
July 7, 2026 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Image.android.jsonly forwards theheadersprop to the native view whensourceresolves to an array — for a plain{uri, headers}object it silently drops them, so the request still went out with the genericokhttp/...UA and Wikimedia kept returning 403.photoImageSource()now returns a single-element array instead of a plain object, so Android's Image pipeline correctly picks up the header.tsc/lint/existing tests.Test plan
tsc --noEmitbun run lintbun run test -- --ci