Skip to content

Remove non-functional drag handle from bottom sheets#60

Merged
dfalling merged 1 commit into
mainfrom
tweak-user-menu
Jul 15, 2026
Merged

Remove non-functional drag handle from bottom sheets#60
dfalling merged 1 commit into
mainfrom
tweak-user-menu

Conversation

@dfalling

Copy link
Copy Markdown
Owner

Summary

  • Removed the decorative grabber handle from the shared Sheet primitive. The handle signaled drag-to-dismiss/expand affordances that the sheet never supported — it only slides open/closed and dismisses via scrim tap or the hardware back button.
  • Bumped the card's paddingTop (8 → 20) to preserve comfortable top spacing now that the handle no longer contributes vertical room.
  • Dropped the now-orphaned handle theme token (type field + light/dark values).

Affects both consumers of Sheet: the account menu and the trip sheet in ElementEditScreen. Neither responds to drag, so the handle was misleading in both.

Testing

  • tsc --noEmit — clean
  • biome check — clean
  • jest --ci — 7 passed

The Sheet primitive drew a grabber handle implying drag-to-dismiss or
expand, but the sheet has no gesture handling — it only opens/closes via
a slide animation and dismisses via scrim tap or back button. The handle
signaled affordances that don't exist, so remove it from the shared
primitive (affecting both the account menu and the trip sheet) and drop
the now-orphaned `handle` theme token.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@dfalling
dfalling enabled auto-merge (squash) July 15, 2026 22:46
@dfalling
dfalling merged commit 0ad3ffc into main Jul 15, 2026
2 checks passed
@dfalling
dfalling deleted the tweak-user-menu branch July 15, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant