Update InstallModuleFromGitHub.psm1#20
Open
DBremen wants to merge 1 commit into
Open
Conversation
Added type to ProjectUri Parameter Fixed issue with $url based on ProjectUri containing extraneous slash character Changed default value for $Branch parameter to 'main'
jonaskuske
reviewed
Nov 27, 2022
| Write-Verbose ("[$(Get-Date)] Retrieving {0} {1}" -f $GitHubRepo, $Branch) | ||
|
|
||
| $url = "https://api.github.com/repos/{0}/zipball/{1}" -f $GitHubRepo, $Branch | ||
| $url = "https://api.github.com/repos{0}/zipball/{1}" -f $GitHubRepo, $Branch |
There was a problem hiding this comment.
I think it'd be clearer to keep this line as-is and apply the fix in line 17 instead:
$GitHubRepo = $ProjectUri.AbsolutePath.Substring(1)
jonaskuske
reviewed
Nov 27, 2022
| param( | ||
| $GitHubRepo, | ||
| $Branch = "master", | ||
| $Branch = 'main', |
There was a problem hiding this comment.
This is a breaking change – probably better to put this in a separate PR so the Uri fix below can be published without having to wait for a 2.x release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added type to ProjectUri Parameter
Fixed issue with $url based on ProjectUri containing extraneous slash character
Changed default value for $Branch parameter to 'main'