Fix dark-on-dark supervision textarea, merge duplicate Supervision UI - #402
Merged
Merged
Conversation
- .cn-textarea-small was missing color: var(--color-text-primary), unlike its -large/-medium siblings, so text fell back to inherited dark-on-dark on the dark input background. - The client detail page had two separate "Supervision" add-forms (a ClientNote note_type=supervision path and a SupervisionItem topic queue). Merged into one: SupervisionItem gains optional resolution_notes/resolved_date, filled in via a new supervision_item_resolve view when marking a topic discussed. Existing supervision-type ClientNotes are migrated in as already-discussed SupervisionItems (migration 0034). - Supervision section is now collapsed by default behind a "+ Supervision" toggle button next to "+ Note"/"+ Session log", matching the existing note-toggle pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.cn-textarea-smallwas missingcolor: var(--color-text-primary)(unlike its-large/-mediumsiblings), so the supervision-topic textarea rendered dark text on the dark input background.ClientNotenote_type="supervision"dated markdown note, and aSupervisionItemopen/discussed topic queue. Merged into one workflow:SupervisionItemgains optionalresolution_notes/resolved_date, filled in via a newsupervision_item_resolveview when a topic is marked discussed. Existing supervision-typeClientNotes are migrated into already-discussedSupervisionItems (migration0034).Test plan
./dev.py test my_practice.tests.test_clinical my_practice.tests.test_admin my_practice.tests.test_i18n_coverage my_practice.tests.test_css_tokens./dev.py test --fast(full Django + JS suite, after clearing stale parallel-worker test DBs)./dev.py lint(ruff format + lint + Tailwind build)./dev.py i18n— no fuzzy entries, all new/changed msgids given real German translationsnote_typeinput remains, the resolve form/URL render for open items, the cockpit "+ Supervision" shortcut correctly toggles the (now-collapsible) sectionSupervisionItemrows)🤖 Generated with Claude Code