Fix DCS and SPI events never reaching Flutter listeners - #158
Merged
Conversation
Two long-standing wire-string mismatches meant these events were silently dropped in the default branch of the events handler: - DCS: both native platforms send "onDCSSignatureReady"/"onDCSSignatureError" (the iOS SDK's own listener properties are named that way), but the Dart handler matched "onDcsSignature*". Aligned the two case strings with native. The public EventListener field names are unchanged to avoid a breaking API change. - SPI: the Dart handler had no case arm for any of the 7 SPI events even though EventListener declares them all. Added the missing arms. Android also sent 4 of them without the "on" prefix, unlike iOS; aligned those on the "on..." form. Also wire onDcsSignatureReady/onDcsSignatureError and onIntegrationError into the example app so the DCS fix is observable in the event log.
pmerlet-at-didomi
previously approved these changes
Aug 4, 2026
pmerlet-at-didomi
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two long-standing wire-string mismatches meant these events were silently dropped in the default branch of the events handler:
DCS: both native platforms send "onDCSSignatureReady"/"onDCSSignatureError" (the iOS SDK's own listener properties are named that way), but the Dart handler matched "onDcsSignature*". Aligned the two case strings with native. The public EventListener field names are unchanged to avoid a breaking API change.
SPI: the Dart handler had no case arm for any of the 7 SPI events even though EventListener declares them all. Added the missing arms. Android also sent 4 of them without the "on" prefix, unlike iOS; aligned those on the "on..." form.
Also wire onDcsSignatureReady/onDcsSignatureError and onIntegrationError into the example app so the DCS fix is observable in the event log.