Skip to content

Fix integration test event races (onReady, onSyncDone) #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-chaix-didomi merged 4 commits into from
Aug 5, 2026
Merged

Fix integration test event races (onReady, onSyncDone) #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9028d00
Wait for onReady event in integration test initialize helper
nicolas-chaix-didomi Aug 4, 2026
159ceea
Wait for onSyncDone in integration test sync helper
nicolas-chaix-didomi Aug 4, 2026
fd60053
remove onSyncDone (deprecated) from tests
nicolas-chaix-didomi Aug 5, 2026
43fe51f
Extract if-not-ready initialize guard into InitializeHelper.initializ…
nicolas-chaix-didomi Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions example/integration_test/consent_state_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand All @@ -80,10 +77,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -140,10 +134,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down
15 changes: 3 additions & 12 deletions example/integration_test/get_current_user_status_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -114,10 +111,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -179,10 +173,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down
15 changes: 3 additions & 12 deletions example/integration_test/get_user_status_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -84,10 +81,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -129,10 +123,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down
2 changes: 1 addition & 1 deletion example/integration_test/initialize_with_local_config_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void main() {

await tester.tap(localConfigBoxFinder);

await InitializeHelper.initialize(tester, initializeBtnFinder);
await InitializeHelper.initialize(tester, initializeBtnFinder, isReady: () => isReady);

assertNativeMessage("initialize", okMessage);

Expand Down
10 changes: 2 additions & 8 deletions example/integration_test/language_update_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,7 @@ void main() {
assert(isError == false);
assert(isReady == false);

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand All @@ -94,10 +91,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down
2 changes: 1 addition & 1 deletion example/integration_test/notice_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

await InitializeHelper.initialize(tester, initializeBtnFinder);
await InitializeHelper.initialize(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down
10 changes: 2 additions & 8 deletions example/integration_test/preferences_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -110,10 +107,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down
15 changes: 3 additions & 12 deletions example/integration_test/purpose_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand All @@ -130,10 +127,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand All @@ -154,10 +148,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down
5 changes: 1 addition & 4 deletions example/integration_test/regulation_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down
30 changes: 6 additions & 24 deletions example/integration_test/set_current_user_status_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -125,10 +122,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -194,10 +188,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -264,10 +255,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -340,10 +328,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down Expand Up @@ -416,10 +401,7 @@ void main() {
app.main();
await tester.pumpAndSettle();

if (!isReady) {
// Initialize if not ready
await InitializeHelper.initialize(tester, initializeBtnFinder);
}
await InitializeHelper.initializeIfNeeded(tester, initializeBtnFinder, isReady: () => isReady);

assert(isError == false);
assert(isReady == true);
Expand Down
Loading