Declare FlutterFramework dependency in Package.swift - #160
Open
nicolas-chaix-didomi wants to merge 2 commits into
Open
Declare FlutterFramework dependency in Package.swift#160nicolas-chaix-didomi wants to merge 2 commits into
nicolas-chaix-didomi wants to merge 2 commits into
Conversation
pmerlet-at-didomi
previously approved these changes
Aug 5, 2026
The Flutter tool warns on every iOS build that the plugin's Swift package
is missing a FlutterFramework dependency:
Plugin didomi_sdk has a Package.swift for ios but is missing a
dependency on FlutterFramework.
The manifest linked the Flutter framework via `.linkedFramework("Flutter")`,
which the tool no longer considers sufficient — it validates that the
manifest declares FlutterFramework as a package dependency and references
it from each target (see validatePluginSupportsSwiftPackageManager in
flutter_tools/lib/src/macos/darwin_dependency_management.dart).
Replace the linker settings with the form the tool expects. The
`../FlutterFramework` path resolves at app build time: the Flutter tool
generates that package alongside the copied plugin package, so it is not
expected to exist in this repository.
Verified: `swift package dump-package` parses the manifest, and
`pod lib lint didomi_sdk.podspec` still passes.
nicolas-chaix-didomi
force-pushed
the
chore/spm-flutterframework-dependency
branch
from
August 5, 2026 07:56
41400e6 to
b27ca92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Swift Package Manager support for the iOS plugin now depends on Flutter the way SPM expects, instead of bare linker flags.
FlutterFrameworkpackage as a dependency at../FlutterFramework. The Flutter tool generates that package next to the plugin package when building an app, so the relative path resolves at build time.DidomiSwiftanddidomi_sdk) now depend on theFlutterFrameworkproduct..linkedFramework("Flutter", .when(platforms: [.iOS]))linker settings from both targets, which the product dependency replaces.This gives the targets the Flutter module for compilation, not just a link-time framework reference.