Skip to content

Fix release workflow syntax error from changelog interpolation - #161

Merged
nicolas-chaix-didomi merged 1 commit into
mainfrom
fix/release-workflow-changelog-syntax-error
Aug 5, 2026
Merged

Fix release workflow syntax error from changelog interpolation#161
nicolas-chaix-didomi merged 1 commit into
mainfrom
fix/release-workflow-changelog-syntax-error

Conversation

@nicolas-chaix-didomi

Copy link
Copy Markdown
Contributor

Summary

  • The release workflow's github-script step interpolated ${{ env.change_log }} (a multi-line string with backticks/quotes) directly into a JS source string, which broke the release for 2.31.0 with SyntaxError: Invalid or unexpected token.
  • Pass the changelog and version through env: instead, and reference them via process.env inside the script — this avoids splicing arbitrary text into JS source.

Test plan

  • Trigger the release workflow (or workflow_dispatch) and confirm Create Release step succeeds with a multi-line changelog body containing backticks.

Interpolating the multi-line changelog (with backticks/quotes) directly
into the github-script JS source string broke on release 2.31.0. Pass it
via env instead and reference it through process.env in the script.
@nicolas-chaix-didomi
nicolas-chaix-didomi merged commit a0904bd into main Aug 5, 2026
7 checks passed
@nicolas-chaix-didomi
nicolas-chaix-didomi deleted the fix/release-workflow-changelog-syntax-error branch August 5, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants