fix(task-board): fix orphan detection and add session linking

[dimakis]

Summary

• Fix orphan detection: getActiveSessionIds() was returning SDK session IDs but task sessionId stores client IDs — comparison never matched, so dead tasks stayed "running" forever. Now returns client IDs.
• Clickable session hash: Running tasks show a tappable session hash that navigates to the session's chat view. Uses the resolved SDK session ID (enriched on broadcast).
• Source link in session banner: Sessions spawned from Telos items or Task Board goals show a tappable link ("Task Board" / "Telos") in the session banner header.

Test plan

• Task orchestrator orphan detection tests pass (46/46)
• SessionBanner tests pass with router context (9/9)
• TypeScript type check clean on all changed files
• Manual: start a Task Board goal, verify running tasks show clickable session hash
• Manual: verify dead tasks get reclaimed (kill a headless session, wait for tick)
• Manual: verify Telos-spawned session shows "Telos" link in banner

🤖 Generated with Claude Code

[dimakis]

Centaur Review

Found 6 issue(s) (1 critical) (3 warning).

frontend/src/components/__tests__/TaskNode.test.tsx

The orphan detection fix is correct — aligns getActiveSessionIds with the clientId keys stored in tasks. However, TaskNode tests are broken (missing Router wrapper + missing sdkSessionId in mock), and the enrichment logic is duplicated between app.ts and index.ts.

• 🔴 regressions: TaskNode now calls useNavigate() (line 4 of TaskNode.tsx), but the existing tests render <TaskNode> without a Router context. Every test in this file will crash with "useNavigate() may be used only in the context of a component." Needs a MemoryRouter wrapper like SessionBanner tests got. [fixable]
• 🟡 regressions (L11): makeTask() helper is missing the new required sdkSessionId: string | null field added to the Task type (frontend/src/types/task.ts:30). This will cause a TypeScript compile error in the test file. Add sdkSessionId: null to the default object. [fixable]

server/index.ts

The orphan detection fix is correct — aligns getActiveSessionIds with the clientId keys stored in tasks. However, TaskNode tests are broken (missing Router wrapper + missing sdkSessionId in mock), and the enrichment logic is duplicated between app.ts and index.ts.

• 🟡 style (L226): The enrichWithSdkSessionId lambda duplicates the enrichTasksWithSdkSessionId function already defined in server/app.ts:628. Both do the same recursive tree walk with registry.get(t.sessionId)?.sessionId. Extract to a shared helper to avoid the logic drifting apart. [fixable]

frontend/src/components/__tests__/SessionBanner.test.tsx

The orphan detection fix is correct — aligns getActiveSessionIds with the clientId keys stored in tasks. However, TaskNode tests are broken (missing Router wrapper + missing sdkSessionId in mock), and the enrichment logic is duplicated between app.ts and index.ts.

• 🟡 missing_tests: SessionBanner tests were updated with MemoryRouter wrapping but no test exercises the new sourceLink prop — rendering the link label, click navigation to /tasks or /todos, the hasTelos vs hasGoal priority logic, or the edge case where telosTaskId === goalId (which suppresses the Telos link). [fixable]

frontend/src/components/TaskNode.tsx

The orphan detection fix is correct — aligns getActiveSessionIds with the clientId keys stored in tasks. However, TaskNode tests are broken (missing Router wrapper + missing sdkSessionId in mock), and the enrichment logic is duplicated between app.ts and index.ts.

• 🔵 missing_tests (L72): The new ActiveContextLine component with clickable session navigation has no test coverage — the click handler, the fallback to plain text when sdkSessionId is missing, and keyboard navigation are all untested. [fixable]

server/app.ts

The orphan detection fix is correct — aligns getActiveSessionIds with the clientId keys stored in tasks. However, TaskNode tests are broken (missing Router wrapper + missing sdkSessionId in mock), and the enrichment logic is duplicated between app.ts and index.ts.

• 🔵 missing_tests (L628): The enrichTasksWithSdkSessionId helper has no unit test. A test verifying the recursive enrichment (nested children) and the null-session fallback would protect against future regressions in the tree walk. [fixable]