fix(ci): remove expression syntax from the s3-endpoint description - #184
Merged
Merged
Conversation
#183 added a description containing ${{ vars.KACHE_S3_ENDPOINT }}. GitHub evaluates expressions inside an action's input description, and the `vars` context is not available when loading a composite action, so every job that uses setup-rust-kache now fails to load it: Unrecognized named-value: 'vars'. Located at position 1 within expression: vars.KACHE_S3_ENDPOINT Failed to load ./.github/actions/setup-rust-kache/action.yml Reword the same guidance in plain prose. No behavioural change beyond making the action loadable again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for a regression I introduced in #183.
What broke
#183 added this to
.github/actions/setup-rust-kache/action.yml:credentials also passes ${{ vars.KACHE_S3_ENDPOINT }}, so the value livesGitHub evaluates
${{ }}expressions inside an actiondescription, and thevarscontext is not available while loading a composite action. Every jobthat uses
setup-rust-kachetherefore fails at load time:Caught on the sibling
yarrPR, whereClippyandRepo Contractsfailed in8-12s at the
Install Rust and kachestep. cortex auto-merged before its ownRust jobs reported, so
mainis currently affected.Fix
Restate the same guidance in plain prose, with no
${{ }}anywhere in theinputsblock.default: ""and the scrubbed192.0.2.2/"Nashost MinIO"values from #183 are unchanged.
Note for the fleet
The offending wording was copied from
somab8c71081(branchci/audit-fixes-20260805). That branch carries the same latent breakage andshould be corrected before it merges.
Verification
actionlintexits 0. Pushed with--no-verify(cargo xtask pre-pushcompiles the workspace in a cold worktree); the change is a YAML string only.