Skip to content

⚡ [performance improvement] Use set instead of list for keyword membership checks#30

Open
dioncx wants to merge 1 commit into
mainfrom
perf/use-set-instead-of-list-in-smart-py-6008077062722791509
Open

⚡ [performance improvement] Use set instead of list for keyword membership checks#30
dioncx wants to merge 1 commit into
mainfrom
perf/use-set-instead-of-list-in-smart-py-6008077062722791509

Conversation

@dioncx

@dioncx dioncx commented Jun 12, 2026

Copy link
Copy Markdown
Owner

💡 What:
Replaced list literals ([...]) with set literals ({...}) for constant keyword membership checks in the _detect_negation function within json_memory/smart.py.

🎯 Why:
Python compiles x in {"a", "b", "c"} into a fast frozenset lookup, giving an $O(1)$ time complexity instead of an $O(N)$ linear search through a list. This provides a direct performance boost with no behavioral changes.

📊 Measured Improvement:
Measured using timeit for 10,000,000 iterations:

  • Baseline (Lists): 2.1122s
  • Optimized (Sets): 0.2978s
  • Result: ~86% reduction in execution time for membership checks.

PR created automatically by Jules for task 6008077062722791509 started by @dioncx

Co-authored-by: dioncx <148190661+dioncx@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant