Skip to content

🧹 [Code Health] Fix silent exceptions in SmartMemory by using proper logging#53

Open
dioncx wants to merge 1 commit into
mainfrom
fix-silent-exceptions-15456213792516027819
Open

🧹 [Code Health] Fix silent exceptions in SmartMemory by using proper logging#53
dioncx wants to merge 1 commit into
mainfrom
fix-silent-exceptions-15456213792516027819

Conversation

@dioncx

@dioncx dioncx commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Replaced all instances of except Exception: pass with except Exception as e: logger.warning(...) in json_memory/smart.py.

🎯 What: Replaced anti-patterns of silently swallowing generic exceptions (except Exception: pass) with standard logging to capture error visibility.
💡 Why: Catching Exception blindly makes debugging very difficult because errors related to state persistence, file permission issues, serialization failures, or backwards compatibility issues fail without any noise. Logging these failures ensures they are observable without breaking the fallback mechanisms designed into the program flow.
Verification:

  • Ran the full pytest suite ensuring all tests passed.
  • Kept all existing fallback behaviours intact (e.g. self._episodes = [] on failures) so the code's functional logic is unchanged.
  • Ensured standard PEP 8 imports formatting for the logging module.
    Result: A more maintainable and debuggable codebase.

PR created automatically by Jules for task 15456213792516027819 started by @dioncx

…logging

Co-authored-by: dioncx <148190661+dioncx@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant