fix(api): default invalid skills page query - #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/skills?page=values to page 1 instead of lettingNaNserialize asnullin pagination metadataTest Plan
npm test --workspace @agentvouch/web -- __tests__/api/skills-get-cache.test.ts --maxWorkers=1 --no-fileParallelismnpm run format:checknpm run lint:webnpm run typechecknpm test --workspace @agentvouch/web -- --maxWorkers=1 --no-fileParallelism(128 files / 928 tests)npm exec --workspace @agentvouch/web -- next build --webpackgit diff --checkNotes
No live database, wallet, or browser flow was run. The webpack build passed with the repository's existing
oxdynamic-dependency warning and expected static-generation fallback logs becauseDATABASE_URLis absent locally.