[DAP-18] Remove PartialBatchSelector from CollectionJobResp - #4818
Merged
Conversation
The DAP spec dropped the field (draft-ietf-ppm-dap#778); the response
is now {report_count, interval, leader_encrypted_agg_share,
helper_encrypted_agg_share}. Cascades into the collector's public
Collection type, the collect CLI's batch-id output, and the interop
collector, which can no longer observe a leader-selected batch ID from
the response.
Fixes #4783
jcjones
changed the title
divergentdave
approved these changes
Aug 20, 2026
tgeoghegan
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DAP spec dropped the field (ietf-wg-ppm/draft-ietf-ppm-dap#778); the response is now
{report_count, interval, leader_encrypted_agg_share, helper_encrypted_agg_share}. Cascades into the collector's public Collection type, the collect CLI's batch-id output, and the interop collector, which can no longer observe a leader-selected batch ID from the response.Fixes #4783