Add detail fields to invalid message errors - #4821
Open
divergentdave wants to merge 1 commit into
Open
Conversation
divergentdave
force-pushed
the
david/invalid-message-detail
branch
from
August 20, 2026 23:36
5d8f8e0 to
bbd9ab1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the main branch, we are better about adding detail fields to invalid message errors than on the release branch. This PR backfills some detail fields where we use the invalid message problem type. I left the
CodecErrorcase message fairly generic, even though that's the one I ran into most recently, because I wanted to be conservative about reflecting sensitive information in error messages. The other cases are easier to justify because they use&'static strvalues.