Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes unsound panic-unwind behavior in LinkedHashMap::clear() (Issue #43) by ensuring the value-list guard is left in a consistent empty state even if dropping an entry panics, and adds a regression test to cover the scenario where clear() panics and the panic is caught.
Changes:
- Make
drop_value_nodesdetach the guard from the value list before dropping any nodes, preventing stale moved-out nodes from remaining reachable after a caught panic. - Adjust node/entry drop ordering so that, if an entry’s
Droppanics, unwinding continues from the next node without revisiting the already-taken entry. - Add a regression test that catches a panic from
clear()and then drops the map to ensure no stale nodes are traversed/dropped again.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/linked_hash_map.rs |
Refactors drop_value_nodes to detach the guard first and to be panic-unwind safe during entry drops. |
tests/linked_hash_map.rs |
Adds a regression test that catches a panic during clear() and validates the map can be safely dropped afterward. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43.