Run test suite with druntime, not Phobos#23213
Draft
dkorpel wants to merge 7 commits into
Draft
Conversation
dkorpel
force-pushed
the
testrunner-phobos
branch
from
e8d7700 to
02d85de
Compare
| ] | ||
| } | ||
| } | ||
| } No newline at end of file |
dkorpel
force-pushed
the
testrunner-phobos
branch
from
02d85de to
68293cb
Compare
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#23213" |
dkorpel
force-pushed
the
testrunner-phobos
branch
from
969f6ba to
d633c46
Compare
The dmd test suite is supposed to be independent of Phobos. Consolidate ^^ related tests, and only link Phobos if a test has RUNNABLE_PHOBOS_TEST or COMPILABLE_MATH_TEST set. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
VisualD passes the dmd build configuration (e.g. Debug, RelWithAsserts) as BUILD, but the druntime/phobos makefiles only accept debug or release. ensureDruntime then failed with "Unrecognized BUILD=Debug". Normalize the runtime library flavor independently from the compiler configuration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ensureDruntime invoked the druntime Makefile without DMD=, so its default DMD path (generated/<os>/<build>/<model>/dmd) pointed at a nonexistent binary on the VisualD CI (dmd lives under RelWithAsserts/), triggering a "make -C .. dmd" that failed compiling build.d against absent Phobos. Pass the existing compiler explicitly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The dshell prebuilt library and per-test driver were built with the host compiler (e.g. LDC 1.23 on the VisualD CI), which is too old to parse the current druntime/Phobos sources (short '=>' function bodies etc.), causing parse errors when their imports were analyzed. They also import Phobos and link against each other, so build both with the compiler under test using PHOBOS_DFLAGS instead, matching the pre-druntime-only behaviour. Also strip the benign LNK4255 'multiple objects of the same name' linker warning: druntime.lib is built as one 'dmd -lib' archive and contains several objects sharing a basename (memory.obj etc.), so the MS linker warns when linking with -g, leaking into tests that expect no output. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`const(string)[string].dup` yields `const(string)[string]`, which doesn't implicitly convert to the mutable `string[string]` spawnProcess wants. Copy the entries into a mutable AA explicitly instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dkorpel
force-pushed
the
testrunner-phobos
branch
from
da22846 to
e35773c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #16587
Problems with the current situation:
This PR ensures druntime is built and only links with libdruntime.a instead of libphobos.a, unless a test has RUNNABLE_PHOBOS_TEST or COMPILABLE_MATH_TEST directives. (These already existed, but only for documentation purposes).
The ^^ related tests have been consolidated in runnable/pow.d because xtest46.d is 8000 lines, and we don't want to accidentally use Phobos outside the few remaining ^^ cases.