Fix #23143 - importC: translate function alias macros to aliases#23214
Draft
dkorpel wants to merge 1 commit into
Draft
Fix #23143 - importC: translate function alias macros to aliases#23214dkorpel wants to merge 1 commit into
dkorpel wants to merge 1 commit into
Conversation
dkorpel
force-pushed
the
fix23143-importc-alias-macros
branch
2 times, most recently
from
fe78287 to
5f00849
Compare
Contributor
|
This should not restrict it to functions. Same issue with: |
A `#define ID identifier` whose body is a single declared identifier (e.g. `#define mpz_init __gmpz_init` in gmp.h) was abandoned, leaving the macro name undefined in D. Translate such object-like macros to `alias ID = identifier;` so they resolve to the function/type/variable. The target must be declared in the same translation unit (or an earlier #define): aliasing an undefined identifier would error eagerly, which system headers trigger by #define-ing keywords to compiler builtins (e.g. `#define __func__ __FUNCTION__`, `#define __restrict restrict`). Self-referential macros (glibc's `#define stdin stdin`) are skipped, as they would otherwise shadow the declaration they name. On Windows the C library's `complex` macro resolves to a struct, which ImportC now aliases; druntime's `core.stdc.complex.complex` is an alias of `creal`, so importc_compare flags the expected size difference - add it to that test's known problems. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dkorpel
force-pushed
the
fix23143-importc-alias-macros
branch
from
5f00849 to
cf67313
Compare
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
thewilsonator
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23143
Recognize
#define ID identifierand define an alias ifidentifierwas seen before.