[2024 edition] Deprecate method prefix type qualifiers#23215
Open
ntrel wants to merge 3 commits into
Open
Conversation
dkorpel
reviewed
Jun 10, 2026
dkorpel
left a comment
dkorpel
left a comment
Contributor
There was a problem hiding this comment.
Implementation looks good, but the first edition is limited to (a subset of) existing deprecations which will be discussed Friday, so now new deprecations. I'm down to merge this as is already and fixup the edition condition later though.
| if (mod.edition >= Edition.v2024 && storageClass & STC.TYPECTOR) | ||
| { | ||
| typeof(AST.Declaration.storage_class) stc = storageClass & STC.TYPECTOR; | ||
| auto qual = (AST.stcToString(stc) ~ '\0').ptr; |
Contributor
There was a problem hiding this comment.
Slight preference to keep this a D string and pass it as "%.*s", cast(int) qual.length, qual.ptr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20474.