🩺 Log rejected SAML auth responses with error reason and relay-state context - #50
Open
Actalab wants to merge 1 commit into
Open
🩺 Log rejected SAML auth responses with error reason and relay-state context#50Actalab wants to merge 1 commit into
Actalab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Logger.warningat the single choke point whereconsume_signin_response/1rejects an IdP auth response, so failures surface the concrete reason (:invalid_relay_state, signature/decode errors,:invalid_idp_id, …) instead of being swallowed into a session that is dropped on the cross-site ACS POST.Logs the error,
idp_id, whether the IdP echoed aRelayState, and whether it was still in the cache — enough to tell apart a dropped/mangled RelayState from a decode/validation failure.