use error channel for Watch/WatchTree#139
Open
danielkrainas wants to merge 8 commits intodocker:masterfrom
Open
use error channel for Watch/WatchTree#139danielkrainas wants to merge 8 commits intodocker:masterfrom
danielkrainas wants to merge 8 commits intodocker:masterfrom
Conversation
Author
|
Just wanted to bump in case this hasn't gotten eyes because of the build failure: looks like the build failed because of the DNS DDoS that was going on at the time and killed GH intermittently. |
danielkrainas
force-pushed
the
28-watch-error-chan
branch
from
424ffb7 to
ae24f5e
Compare
danielkrainas
force-pushed
the
28-watch-error-chan
branch
from
ae24f5e to
9d6a854
Compare
Signed-off-by: Danny Krainas <dkrainas87@gmail.com>
Signed-off-by: Danny Krainas <dkrainas87@gmail.com>
Signed-off-by: Danny Krainas <dkrainas87@gmail.com>
Signed-off-by: Danny Krainas <dkrainas87@gmail.com>
Signed-off-by: Danny Krainas <dkrainas87@gmail.com>
Signed-off-by: Danny Krainas <dkrainas87@gmail.com>
Signed-off-by: Danny Krainas <dkrainas87@gmail.com>
Signed-off-by: Danny Krainas <dkrainas87@gmail.com>
danielkrainas
force-pushed
the
28-watch-error-chan
branch
from
9d6a854 to
1530dfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #28 by swapping out
errorfor<-chan errorand adds a helper to create a preloaded channel for immediate error'd returns.