[redis] add redis backend#143
Open
hsinhoyeh wants to merge 2 commits intodocker:masterfrom
Open
Conversation
793df01 to
0861b5b
Compare
Author
|
travis failed due to #144, not redis implementation itself |
Contributor
1. imp interface of libkv with redis command and lua script 2. use key space notification for watchXXX/Lock features, so only work for redis version >= 2.8.0 fixed docker#116 Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
|
Please sign your commits following these rules: $ git clone -b "issue-116" git@github.com:hsinhoyeh/libkv.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354269296
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
|
Any idea when this will be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noted: this implementation haven't been battle tested, any further testcases will be appreciated
fixed #116