Skip to content

[redis] add redis backend#143

Open
hsinhoyeh wants to merge 2 commits intodocker:masterfrom
hsinhoyeh:issue-116
Open

[redis] add redis backend#143
hsinhoyeh wants to merge 2 commits intodocker:masterfrom
hsinhoyeh:issue-116

Conversation

@hsinhoyeh
Copy link
Copy Markdown

  1. imp interface of libkv with redis command and lua script
  2. use key space notification for watchXXX/Lock features, so only work for redis version >= 2.8.0

noted: this implementation haven't been battle tested, any further testcases will be appreciated

fixed #116

@hsinhoyeh
Copy link
Copy Markdown
Author

travis failed due to #144, not redis implementation itself

@abronan
Copy link
Copy Markdown
Contributor

abronan commented Jan 2, 2017

That's a really cool PR, excited to see this landing :)

I'm no longer a maintainer of the library but there are a few people that could help reviewing this. @samalba is a redis guru and will certainly like it.

/cc @sanimej for everything libnetwork related.

1. imp interface of libkv with redis command and lua script
2. use key space notification for watchXXX/Lock features, so only work for
redis version >= 2.8.0

fixed docker#116

Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
@GordonTheTurtle
Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "issue-116" git@github.com:hsinhoyeh/libkv.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354269296
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: hsinhoyeh <yhh92u@gmail.com>
@saracen
Copy link
Copy Markdown

saracen commented Jan 31, 2018

Any idea when this will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design review on redis/rediscluster store

4 participants