add dynamodDB#146
Open
tskinn wants to merge 1 commit intodocker:masterfrom
Open
Conversation
Signed-off-by: Taylor Skinner <tskinn12@gmail.com>
|
@tskinn are you willing to complete this PR? I would like to use the dynamodb backend as well. |
Author
|
@project0 yes I am. Is the PR missing anything for it to be merged or do we just need to bug the maintainers? |
|
@tskinn I think fixing the CI tests will help for the approvement ;-) |
Author
|
@project0 it was the consul script that failed on that CI test run. Do you know how to trigger a run again? |
|
@tskinn Usually changes on the branch of PR will trigger an new unit test, probably merging (rebased?) the last changes will re-run the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Taylor Skinner tskinn12@gmail.com