Possibility to tune disqusIdentifier#23
Open
varya wants to merge 3 commits into
Open
Conversation
Member
balupton
approved these changes
Apr 17, 2017
| disqusDeveloper = if 'production' in @getEnvironments() then '0' else '1' | ||
| pageUrl = @getPageUrl() | ||
| disqusIdentifier = @document.slug | ||
| if @document.disqusIdentifier isnt undefined |
Member
There was a problem hiding this comment.
should be if @document.disqusIdentifier?
Member
|
I have become too preoccupied by other things to review, merge, and release this PR. However, you should have received an invite a while ago to join the DocPad Extras Team, which will give you write access to this repository, so you can merge in the PR. For an orientation, or if you need any assistance following the semi-automatic release process from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When moving my blog from Jekyll to DocPad I faced the need to preserve Disqus comments which I already had to my posts. But I used different code to embed Disqus which did not provide
window.disqus_identifier. Thus, to preserve comments I need now to definewindow.disqus_identifierasundefinedfor my older posts. I decided that this would be not very nice to modify@document.slugfor this. So, I think this would be much better to have optionaldisqusIdentifierattribute which takes care of it.