Validate OneLoc GitHub App service connection opt-ins - #17393
Open
missymessa wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0e1a942f-a44f-4e3a-8d35-af3fe8bee535
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens the OneLocBuild Azure Pipelines template by validating GitHub App authentication opt-ins early, so misconfigured service-connection defaults fail during template expansion with an actionable error, and updates documentation to describe the required override for non-dnceng/internal and non-DevDiv/DevDiv projects.
Changes:
- Add a template-expansion validation error when
UseGitHubAppAuthenticationInOtherProjectsis enabled outside the supported projects while retaining the defaultdnceng-oneloc-githubappservice connection. - Update the GitHub App documentation to explicitly require a project-scoped
GitHubAppServiceConnectionoverride for non-default projects.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/core-templates/job/onelocbuild.yml | Adds early validation to catch invalid OneLoc GitHub App service-connection defaults for external project opt-ins. |
| Documentation/OneLocBuildGitHubApp.md | Documents the required service-connection override behavior for external opt-ins and clarifies failure mode. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0e1a942f-a44f-4e3a-8d35-af3fe8bee535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dnceng/internalandDevDiv/DevDivopts into OneLoc GitHub App authentication without overriding the dnceng-scoped service connectionWhy
The default
dnceng-oneloc-githubappconnection does not exist in arbitrary Azure DevOps projects. Without this guard, an opt-in that omitsGitHubAppServiceConnectionfails later with a less actionable service-connection-not-found or authorization error.This is the source fix for feedback on dotnet/roslyn-sdk#1281.
Validation
git diff --checkTracking: https://dev.azure.com/dnceng/internal/_workitems/edit/12312