Skip to content

Added DotNetBuild=true target in NativeAotTestApp project #68679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashutoshjadhav9 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added DotNetBuild=true target in NativeAotTestApp project #68679

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
678df34
Added DotNetBuild:true target in NativeAotTestApp project
ashutoshjadhav9 Aug 21, 2026
4f0c1e7
Merge branch 'main' into main
ashutoshjadhav9 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Components/Testing/testassets/NativeAotTestApp/NativeAotTestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<UseAspNetCoreSharedRuntime>false</UseAspNetCoreSharedRuntime>
<RuntimeIdentifier Condition="'$(DotNetBuild)' == 'true'">$(TargetRuntimeIdentifier)</RuntimeIdentifier>

@javiercn javiercn Aug 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please scope this to the unsupported rid

@omajid omajid Aug 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern is used in many places without scoping:

aspnetcore/src/Servers/IIS/IIS/test/testassets/TestTasks/TestTasks.csproj

Line 7 in de8ed19

<RuntimeIdentifiers Condition="'$(DotNetBuild)' == 'true'">$(TargetRuntimeIdentifier)</RuntimeIdentifiers>

aspnetcore/src/Hosting/test/testassets/BasicLinkedApp/BasicLinkedApp.csproj

Line 7 in de8ed19

<RuntimeIdentifier Condition="'$(DotNetBuild)' == 'true'">$(TargetRuntimeIdentifier)</RuntimeIdentifier>

Can you help us understand why scoping here is required?

<DoNotApplyWorkaroundsToMicrosoftAspNetCoreApp>false</DoNotApplyWorkaroundsToMicrosoftAspNetCoreApp>
<RuntimeIdentifiers>$(TargetRuntimeIdentifier)</RuntimeIdentifiers>
<JsonSerializerIsReflectionEnabledByDefault>true</JsonSerializerIsReflectionEnabledByDefault>
Expand Down
Loading