[Blazor] Document Components design invariants - #68704
Draft
PureWeen wants to merge 2 commits into
Draft
Conversation
Adds a Design invariants section to src/Components/AGENTS.md covering render mode agnosticism, HttpContext access, cross-render-mode service registration, rendering and the synchronization context, IHandleEvent, trim/AOT annotations, dependencies, and async coordination in tests. Each rule was checked against current source, and the legitimate exceptions are recorded alongside it so the guidance does not produce false review findings. Also clarifies that Selenium is the E2E framework for this area and that the Playwright references are the Playwright MCP browser tool used for manual validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the source-grounded rules while removing implementation inventories, file-path walkthroughs, and duplicated analyzer scope from the nearest-wins guidance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds source-grounded design invariants to
src/Components/AGENTS.md, with legitimate exceptions documented alongside each rule so the guidance does not create false review findings.The guidance covers:
HttpContextaccess and cross-render-mode service registrationStateHasChanged,InvokeAsync, andIHandleEventbehaviorEach rule was checked against the current source tree before inclusion. Stale, withdrawn, out-of-repo, or unverifiable claims from #66964 were deliberately excluded. The original maintainer review that motivated this grounding pass is Javier's review on #66964.
Validation
IHttpContextAccessorhas no shipping Components source usagesStateHasChangedguidance in analyzer BL0012 and its explicit lambda/local-function exclusionssrc/Components/AGENTS.mdblob on upstreammainwas unchanged before applying the editgit diff --checkDocumentation only; no runtime behavior changes.