Fail pending server JS interop calls when circuits disconnect - #68714
Open
imsouvik wants to merge 3 commits into
Open
Fail pending server JS interop calls when circuits disconnect#68714imsouvik wants to merge 3 commits into
imsouvik wants to merge 3 commits into
Conversation
Contributor
|
Thanks for your PR, @imsouvik. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail pending server JS interop calls when circuits disconnect
Summary of the changes (Less than 80 chars)
Fail pending server JS interop calls when circuits disconnect
Description
Server-side JS interop calls are tracked in
JSRuntimeuntilEndInvokeJSreceives the client result. If SignalR closes the connection before the result reachesEndInvokeJSFromDotNet, such as when the incoming JS interop result exceeds the receive message size limit, the pending call is never completed and only observes caller cancellation or timeout.This adds a protected
JSRuntimehelper for derived runtimes to fail all pending async JS calls, and hasRemoteJSRuntimeuse it when the circuit disconnects or transfers to another connection. It also rejects new JS interop calls while the circuit client is disconnected and attempting to reconnect.Fixes #67479.
Testing
git diff --check: passed.