Skip to content

[release/11.0-rc1] Run DirectTls handshake user callbacks off the epoll pump thread - #68751

Merged
wtgodbe merged 1 commit into
dotnet:release/11.0-rc1from
DeagleGross:backport-68664-to-release-11-rc1
Aug 24, 2026
Merged

[release/11.0-rc1] Run DirectTls handshake user callbacks off the epoll pump thread#68751
wtgodbe merged 1 commit into
dotnet:release/11.0-rc1from
DeagleGross:backport-68664-to-release-11-rc1

Conversation

@DeagleGross

@DeagleGross DeagleGross commented Aug 24, 2026

Copy link
Copy Markdown
Member

Backport of #68664 to release/11.0-rc1.

…net#68664)

* user callbacks running on thread pool

* fix leaking pool problems

* nit comments

* more debugable DrainWakeup

* tests & nits

* public API comments about thread pool dispatch

* split up types

* fix race condition

* fix async disposal of directtlsconnection & exitSignal relation

* simplify SNI read

* drop handshake on SetRemoteCertificateValidationResult failure

* unreachable for non-fd flow

* ResumeSuspendedHandshake not finding fd should be unreachable

* unrechable for non-existing callback type

* stable channelRead on acceptAsync & wrapping _connectionClosedTokenSource cancellation

* rephrase the comment
Copilot AI lite review requested due to automatic review settings August 24, 2026 16:38
@DeagleGross DeagleGross self-assigned this Aug 24, 2026
@DeagleGross DeagleGross added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Aug 24, 2026
Copilot stopped reviewing on behalf of DeagleGross due to an error August 24, 2026 16:58
@wtgodbe

wtgodbe commented Aug 24, 2026

Copy link
Copy Markdown
Member

Approved over email

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hi @DeagleGross. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@wtgodbe
wtgodbe merged commit db0c572 into dotnet:release/11.0-rc1 Aug 24, 2026
40 checks passed
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Aug 25, 2026
@DeagleGross
DeagleGross deleted the backport-68664-to-release-11-rc1 branch August 25, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants