[release/11.0-rc1] Run DirectTls handshake user callbacks off the epoll pump thread - #68751
Merged
wtgodbe merged 1 commit intoAug 24, 2026
Conversation
…net#68664) * user callbacks running on thread pool * fix leaking pool problems * nit comments * more debugable DrainWakeup * tests & nits * public API comments about thread pool dispatch * split up types * fix race condition * fix async disposal of directtlsconnection & exitSignal relation * simplify SNI read * drop handshake on SetRemoteCertificateValidationResult failure * unreachable for non-fd flow * ResumeSuspendedHandshake not finding fd should be unreachable * unrechable for non-existing callback type * stable channelRead on acceptAsync & wrapping _connectionClosedTokenSource cancellation * rephrase the comment
DeagleGross
requested review from
BrennanConroy,
SamMonoRT and
halter73
as code owners
August 24, 2026 16:38
Copilot stopped reviewing on behalf of
DeagleGross due to an error
August 24, 2026 16:58
wtgodbe
approved these changes
Aug 24, 2026
Member
|
Approved over email |
Contributor
|
Hi @DeagleGross. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #68664 to release/11.0-rc1.